Rewrite rule from scf to cf #404
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
function can have a return value even when we are talking about Python
functions, e.g when one write
```python
def foo(x: int):
pass
```
we can interpret this as assigning a value of `Method` to the variable
`foo`. This makes downstream analysis and codegen easier because now we
have a place to store what the function represents
weinbe58
commented
May 15, 2025
|
fyi I think this PR is currently blocked by #406 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New Files
Modified FilesNo covered modified files...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR implements the rewrite rule from SCF to CF dialect.
This rule must be applied in a fixed point fashion and works by walking a ssacfg region looking for
scf.Forandscf.IfElse. when if finds these statements it inserts their body blocks and usescfto create the appropriate cfg for those statements. This only implements it for one level of nesting; hence, it should be applied in a fixed-point fashion.