[calvo_machine_learn] Replace np.sum(a * b) with a @ b #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcky
reviewed
Aug 5, 2025
| @@ -567,7 +567,7 @@ def compute_θ(μ, α=1): | |||
|
|
|||
| # Compute the weighted sums for all t | |||
| weighted_sums = jnp.array( | |||
| [jnp.sum(λ_powers[:T-t] * μ[t:T]) for t in range(T)]) | |||
There was a problem hiding this comment.
@HumphreyYang should we do this for jnp.sum as well as np.sum?
There was a problem hiding this comment.
Many thanks @mmcky, I think it's fine because they behave similarly.
I will do another pass over every lecture once the preview PR is opened!
There was a problem hiding this comment.
thanks @HumphreyYang this is building now
#219
There was a problem hiding this comment.
I'll merge this in and then update #219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace np.sum(a * b) and jnp.sum(a * b) with a @ b
QuantEcon/lecture-python.myst#463