Fix NumPy 2.0 compatibility: replace deprecated .ptp() method calls with np.ptp() #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: mmcky <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
mmcky
August 6, 2025 02:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
match_transport.mdlecture was failing with NumPy 2.0 due to the removal of the.ptp()method from ndarray objects. The error occurred when callingexample_off_diag.plot_H_z():This PR replaces all instances of the deprecated
.ptp()method with the NumPy 2.0 compatiblenp.ptp()function calls in the match_transport lecture:self.support_z.ptp()→np.ptp(self.support_z)(6 instances)self.X_types.ptp()→np.ptp(self.X_types)(4 instances)H_z.ptp()→np.ptp(H_z)(2 instances)The changes are minimal and surgical - only method calls are replaced with function calls, preserving all existing functionality while ensuring compatibility with NumPy ≥ 2.0.
Testing: Verified with NumPy 2.3.2 that the previously failing
example_off_diag.plot_H_z()call now executes successfully without errors.Fixes #225.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.