Skip to content

AR1 Bayes Fixes #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2022
Merged

AR1 Bayes Fixes #253

merged 2 commits into from
Sep 8, 2022

Conversation

Smit-create
Copy link
Member

@Smit-create Smit-create commented Aug 22, 2022

@Smit-create
Copy link
Member Author

I will add further commits to address the comments:

  1. Why do we use both pymc and numpyro?
  2. Some explanation of numpyro.

@jstac
Copy link
Contributor

jstac commented Aug 24, 2022

Many thanks @Smit-create . I will leave it to you and @thomassargent30 to finalize these changes.

@Smit-create
Copy link
Member Author

@thomassargent30 I have added some comments on NUTS. Please review the changes and let me know if you have any suggestions. @mmcky Can you please approve the workflow so that we can check the deployment? Thanks!!

@mmcky
Copy link
Contributor

mmcky commented Aug 28, 2022

hey @Smit-create I have added you as a member for the QuantEcon organisation of GitHub. Maybe that will fix these permissions for running checks etc. Once you accept -- hopefully they will run for you.

@Smit-create
Copy link
Member Author

Maybe that will fix these permissions for running checks etc. Once you accept -- hopefully they will run for you.

Thank you so much! It works.

@Smit-create
Copy link
Member Author

As suggested by @thomassargent30, I will merge this PR and he will push some changes directly to the main branch.

@Smit-create Smit-create merged commit 04948e0 into QuantEcon:main Sep 8, 2022
@Smit-create Smit-create deleted the ar1-bayes-1 branch September 8, 2022 14:41
@thomassargent30
Copy link
Contributor

thomassargent30 commented Sep 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants