Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paraview Colormaps #9

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Paraview Colormaps #9

wants to merge 1 commit into from

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Dec 16, 2019 •
edited
Loading

cc. @ejtovar

Working on supporting Paraview colormaps. I will also add support for importing custom colormaps the same way Paraview does it.

@martinRenou
Copy link
Member Author

Useful links for future self:

@martinRenou martinRenou marked this pull request as draft June 4, 2020 10:16
@martinRenou martinRenou changed the title WIP - Paraview Colormaps Paraview Colormaps Jun 4, 2020
@martinRenou martinRenou force-pushed the colormaps branch 4 times, most recently from b84ab29 to a54187a Compare January 21, 2021 13:11
martinRenou
martinRenou commented Jan 21, 2021
View reviewed changes
Copy link
Member Author

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check how paraview does the interpolation

src/utils/colormaps.ts
break;
case ColorSpace.HSV:
throw 'ColorSpace.HSV not supported';
break;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to review this part of the code

src/utils/colormaps.ts

// Add support for log scales scaleSequentialLog
const divergingColorScale = d3Scale.scaleSequential((value: number) => {
for (let i = 0; i < controlPoints.length - 1; i++) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The complexity of this code might be important

@martinRenou
Copy link
Member Author

Needs a rebase

@martinRenou martinRenou mentioned this pull request Feb 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinRenou