-
Notifications
You must be signed in to change notification settings - Fork 2
External dependencies management #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex-PLACET
wants to merge
25
commits into
QuantStack:main
Choose a base branch
from
Alex-PLACET:external_dependencies_management
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bcb1313
Fetch doctest and sparrow
Hind-M a663f09
Add fetch dependencies option to workflows
Hind-M 55994b0
Handle sparrow target and fetch from main branch
Hind-M 02f67d9
Use different jobs to fetch dependencies
Hind-M edbebe6
Force c++20 when building
Hind-M 8500372
Add cxx settings/properties
Hind-M 361c3db
Add verbose
Hind-M fe5fe00
Change build tests option name (conflict)
Hind-M 3d6cf30
Fix typo
Hind-M 3b101ea
wip
Alex-PLACET 6487c72
fix
Alex-PLACET 682e1e4
try fix
Alex-PLACET 55b424b
fix
Alex-PLACET 32aeb12
wip
Alex-PLACET c4b5cf2
wip
Alex-PLACET 1bf99a7
fix
Alex-PLACET afa83d3
wip
Alex-PLACET 8810947
WIP
Alex-PLACET 643223b
fix
Alex-PLACET e5f4394
fix
Alex-PLACET cc17ae2
fix
Alex-PLACET fc198c2
try fix
Alex-PLACET c29ea64
fix
Alex-PLACET 70bf08c
fix
Alex-PLACET 1a0719f
wip
Alex-PLACET File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ defaults: | |
shell: bash -l -eo pipefail {0} | ||
|
||
jobs: | ||
build_linux: | ||
linux_build_from_conda_forge: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
|
@@ -20,22 +20,67 @@ jobs: | |
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Create build environment | ||
uses: mamba-org/setup-micromamba@v2 | ||
with: | ||
environment-file: ./environment-dev.yml | ||
environment-name: build_env | ||
cache-environment: true | ||
- name: Build sparrow-ipc | ||
|
||
- name: Install external dependencies | ||
run: micromamba install -n build_env -y -f ./environment-dev.yml | ||
|
||
- name: Configure using cmake | ||
run: | | ||
cmake -B build/ -G Ninja \ | ||
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \ | ||
-DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX \ | ||
-DCMAKE_PREFIX_PATH=$CONDA_PREFIX \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why remove this? |
||
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} \ | ||
-DBUILD_TESTS=ON | ||
cmake --build build/ --parallel | ||
cmake -G Ninja \ | ||
-Bbuild \ | ||
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \ | ||
-DCMAKE_INSTALL_PREFIX=%CONDA_PREFIX% \ | ||
-DCMAKE_PREFIX_PATH=%CONDA_PREFIX% \ | ||
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} \ | ||
-DSPARROW_IPC_BUILD_TESTS=ON \ | ||
-DFETCH_DEPENDENCIES_WITH_CMAKE=MISSING | ||
|
||
- name: Build sparrow-ipc | ||
working-directory: build | ||
run: cmake --build . --target sparrow-ipc | ||
|
||
- name: Build tests | ||
working-directory: build | ||
run: cmake --build . --target test_sparrow_ipc_lib | ||
|
||
- name: Run tests | ||
working-directory: build | ||
run: cmake --build . --target run_tests_with_junit_report | ||
|
||
linux_build_fetch_from_source: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
build_type: [Release, Debug] | ||
build_shared: [ON, OFF] | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: Configure using cmake | ||
run: | | ||
cd build | ||
ctest --output-on-failure | ||
cmake -G Ninja \ | ||
-Bbuild \ | ||
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }} \ | ||
-DSPARROW_IPC_BUILD_SHARED=${{ matrix.build_shared }} \ | ||
-DSPARROW_IPC_BUILD_TESTS=ON \ | ||
-DFETCH_DEPENDENCIES_WITH_CMAKE=MISSING | ||
|
||
- name: Build sparrow-ipc | ||
working-directory: build | ||
run: cmake --build . --target sparrow-ipc | ||
|
||
- name: Build tests | ||
working-directory: build | ||
run: cmake --build . --target test_sparrow_ipc_lib | ||
|
||
- name: Run tests | ||
working-directory: build | ||
run: cmake --build . --target run_tests_with_junit_report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,3 +33,5 @@ | |
|
||
# Build directories | ||
/build*/ | ||
.cache | ||
.vscode |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant and should be completely removed.