Conversation
add abstractproperty CompiledCallableDef.call_effects, some breaks + typeignore modifier_compiler: grab effects out of FunctionBuilder (via private field) WIP what LocalCalls are there add effects= to hugr_op, order QAlloc/QFree - fixes test_array.py::test_take_put
…IDE_EFFECTS This reverts commit 99b58d5.
This reverts commit 18c0639.
Contributor
|
Bencher Report| Project | guppylang |
| Branch | acl/order_by_effects2 |
| Testbed | Linux |
🚨 2 Alerts
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | hugr_bytes bytes x 1e3 | 📈 plot 🚷 threshold 🚨 alert (🔔) | 67.70 x 1e3(+1.94%)Baseline: 66.41 x 1e3 | 67.07 x 1e3 (100.93%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | hugr_bytes bytes x 1e3 | 📈 plot 🚷 threshold 🚨 alert (🔔) | 29.72 x 1e3(+3.29%)Baseline: 28.77 x 1e3 | 29.06 x 1e3 (102.27%) |
Click to view all benchmark results
| Benchmark | hugr_bytes | Benchmark Result bytes x 1e3 (Result Δ%) | Upper Boundary bytes x 1e3 (Limit %) | hugr_nodes | Benchmark Result nodes (Result Δ%) | Upper Boundary nodes (Limit %) |
|---|---|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 67.70 x 1e3(+1.94%)Baseline: 66.41 x 1e3 | 67.07 x 1e3 (100.93%) | 📈 view plot 🚷 view threshold | 4,595.00(0.00%)Baseline: 4,595.00 | 4,640.95 (99.01%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 29.72 x 1e3(+3.29%)Baseline: 28.77 x 1e3 | 29.06 x 1e3 (102.27%) | 📈 view plot 🚷 view threshold | 1,301.00(0.00%)Baseline: 1,301.00 | 1,314.01 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile | 📈 view plot 🚷 view threshold | 7.56 x 1e3(-3.50%)Baseline: 7.84 x 1e3 | 7.92 x 1e3 (95.55%) | 📈 view plot 🚷 view threshold | 303.00(-2.26%)Baseline: 310.00 | 313.10 (96.77%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile | 📈 view plot 🚷 view threshold | 10.50 x 1e3(-2.52%)Baseline: 10.77 x 1e3 | 10.88 x 1e3 (96.52%) | 📈 view plot 🚷 view threshold | 404.00(-1.70%)Baseline: 411.00 | 415.11 (97.32%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will close #1747 but still only one effect (strictly ordered, where's we'll want something more like a multi-reader-single-writer for
panic) - just recording the bits pulled out of #2024 to leave that as a pure refactor.Does fix the optimizer removing panicking
array.takethough :-) :-)