feat: Mark unitary qsystem gates with unitary=True - #2152
Draft
nicolaassolini-qntm wants to merge 1 commit into
Draft
nicolaassolini-qntm wants to merge 1 commit into
nicolaassolini-qntm wants to merge 1 commit into
Conversation
Flag the Helios and Sol single- and two-qubit gate primitives as unitary so they can be used inside `control` and `dagger` modifier blocks. The internal hugr ops backing them are given `unitary_flags=UnitaryFlags.Unitary` so the public guppy wrappers pass unitary checking. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
Bencher Report| Project | guppylang |
| Branch | na/qsystem-unitary-gates |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | hugr_bytes | Benchmark Result bytes x 1e3 (Result Δ%) | Upper Boundary bytes x 1e3 (Limit %) | hugr_nodes | Benchmark Result nodes (Result Δ%) | Upper Boundary nodes (Limit %) |
|---|---|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | 📈 view plot 🚷 view threshold | 62.10 x 1e3(0.00%)Baseline: 62.10 x 1e3 | 62.72 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 4,585.00(0.00%)Baseline: 4,585.00 | 4,630.85 (99.01%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | 📈 view plot 🚷 view threshold | 27.83 x 1e3(0.00%)Baseline: 27.83 x 1e3 | 28.11 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 1,301.00(0.00%)Baseline: 1,301.00 | 1,314.01 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile | 📈 view plot 🚷 view threshold | 7.25 x 1e3(0.00%)Baseline: 7.25 x 1e3 | 7.32 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 310.00(0.00%)Baseline: 310.00 | 313.10 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile | 📈 view plot 🚷 view threshold | 9.91 x 1e3(0.00%)Baseline: 9.91 x 1e3 | 10.01 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 411.00(0.00%)Baseline: 411.00 | 415.11 (99.01%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 154 154
Lines 14866 14868 +2
=======================================
+ Hits 13871 13873 +2
Misses 995 995 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
We should wait for Quantinuum/tket2#1905 before completing this PR |
| zz_phase(q1, q2, a) | ||
| zz_max(q1, q2) | ||
|
|
||
| use_dagger.check() |
Contributor
Author
There was a problem hiding this comment.
change this when the tket2 passes are ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags the unitary gate operations in both platform modules as unitary:
helios/__init__.py):phased_x,zz_phase,zz_max,rzsol/__init__.py):phased_x,phased_xx,phased_xx_max,xx_max,yy_max,rz