Conversation
Contributor
|
| Project | guppylang |
| Branch | tt/comptime-barrier |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | hugr_bytes | Benchmark Result bytes x 1e3 (Result Δ%) | Upper Boundary bytes x 1e3 (Limit %) | hugr_nodes | Benchmark Result nodes (Result Δ%) | Upper Boundary nodes (Limit %) |
|---|---|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | 📈 view plot 🚷 view threshold | 62.10 x 1e3(0.00%)Baseline: 62.10 x 1e3 | 62.72 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 4,585.00(0.00%)Baseline: 4,585.00 | 4,630.85 (99.01%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | 📈 view plot 🚷 view threshold | 27.83 x 1e3(0.00%)Baseline: 27.83 x 1e3 | 28.11 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 1,301.00(0.00%)Baseline: 1,301.00 | 1,314.01 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile | 📈 view plot 🚷 view threshold | 7.24 x 1e3(0.00%)Baseline: 7.24 x 1e3 | 7.32 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 310.00(0.00%)Baseline: 310.00 | 313.10 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile | 📈 view plot 🚷 view threshold | 9.91 x 1e3(0.00%)Baseline: 9.91 x 1e3 | 10.01 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 411.00(0.00%)Baseline: 411.00 | 415.11 (99.01%) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
=======================================
Coverage 93.28% 93.28%
=======================================
Files 160 160
Lines 15378 15392 +14
=======================================
+ Hits 14345 14359 +14
Misses 1033 1033 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1190
closes #1189
This PR adds support for using barriers with values produced or manipulated inside
guppy.comptime.It applies the same tracing behavior to array
outputcalls, allowing arrays containing static values to remain static after the call and avoiding unnecessary borrow/repacking operations.Changes:
Implement
BarrierChecker.compute_input_flags, marking every barrier argument asInout.Add an opt-in
preserves_static_inout_valuesproperty to custom call checkers.False, preserving existing custom-function behavior.Enable static inout preservation for:
barrieroutputoverloadsUpdate packed-value reconstruction to:
Add array-output tests covering static and mixed static/dynamic arrays.
Motivation:
Previously, passing a linear value such as a qubit to
barrierinsideguppy.comptimefailed because the custom checker did not implementcompute_input_flags. Dynamic copyable inputs also need to be treated as inout values so the barrier remains connected to the surrounding dataflow and is not eliminated from the compiled HUGR.Some inout operations, such as array
output, should also preserve static Python values instead of replacing them with runtime output representations. The new checker property allows for this.