Conversation
acl-cqc
force-pushed
the
acl/custom_func_default
branch
2 times, most recently
from
September 3, 2026 08:09
55cb4c4 to
da26371
Compare
acl-cqc
force-pushed
the
acl/custom_func_default
branch
from
September 4, 2026 15:31
da26371 to
503bc55
Compare
Contributor
|
Bencher Report| Project | guppylang |
| Branch | acl/custom_func_default |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | hugr_bytes | Benchmark Result bytes x 1e3 (Result Δ%) | Upper Boundary bytes x 1e3 (Limit %) | hugr_nodes | Benchmark Result nodes (Result Δ%) | Upper Boundary nodes (Limit %) |
|---|---|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | 📈 view plot 🚷 view threshold | 62.10 x 1e3(0.00%)Baseline: 62.10 x 1e3 | 62.72 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 4,585.00(0.00%)Baseline: 4,585.00 | 4,630.85 (99.01%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | 📈 view plot 🚷 view threshold | 27.80 x 1e3(0.00%)Baseline: 27.80 x 1e3 | 28.08 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 1,301.00(0.00%)Baseline: 1,301.00 | 1,314.01 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile | 📈 view plot 🚷 view threshold | 7.24 x 1e3(0.00%)Baseline: 7.24 x 1e3 | 7.32 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 310.00(0.00%)Baseline: 310.00 | 313.10 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile | 📈 view plot 🚷 view threshold | 9.86 x 1e3(0.00%)Baseline: 9.86 x 1e3 | 9.96 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 411.00(0.00%)Baseline: 411.00 | 415.11 (99.01%) |
maximilianruesch
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
- Coverage 93.23% 93.23% -0.01%
==========================================
Files 162 162
Lines 15824 15817 -7
==========================================
- Hits 14754 14747 -7
Misses 1070 1070 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
acl-cqc
marked this pull request as ready for review
September 4, 2026 15:42
acl-cqc
commented
Sep 4, 2026
| ArrayIsBorrowedCompiler(), | ||
| checker=ArrayIndexChecker(), | ||
| unitary_flags=UnitaryFlags.Dagger, | ||
| effects=(), |
Contributor
Author
There was a problem hiding this comment.
Ok so actually this can panic if out-of-bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes the default conservative, but I've used Claude to add the missing
effects=()argument to all cases where it wasn't specified, and then manually removed all existingeffects=[Effect.ANY]s