Skip to content

chore: update deps, switch to Python 3.14, remove pyright#81

Merged
qartik merged 4 commits intomainfrom
chore-deps
Dec 17, 2025
Merged

chore: update deps, switch to Python 3.14, remove pyright#81
qartik merged 4 commits intomainfrom
chore-deps

Conversation

@qartik
Copy link
Copy Markdown
Member

@qartik qartik commented Dec 16, 2025

Switched to ty and close #72

Also switched to prek from pre-commit.

@qartik qartik requested review from NathanCQC and Copilot December 16, 2025 22:25
@qartik
Copy link
Copy Markdown
Member Author

qartik commented Dec 16, 2025

Unfortunately no stable pre-commit for ty available just yet.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the project from Python 3.13 to Python 3.14, replaces pyright with ty for type checking, and switches from pre-commit to prek for git hook management. The changes also update dependency versions to use more flexible version constraints.

  • Updates Python version from 3.13 to 3.14 across all configuration files
  • Replaces pyright with ty for type checking
  • Migrates from pre-commit to prek for pre-commit hook management

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ruff.toml Updates target Python version to 3.14
pyproject.toml Updates Python version requirement, replaces pre-commit with prek, removes pyright configuration
README.md Updates documentation to reflect Python 3.14, ty, and prek usage
Makefile Updates lint command to use prek and adds ty check
Dockerfile Updates base image to Python 3.14
.pre-commit-config.yaml Migrates to builtin hooks, updates hook versions, removes pyright hook
.github/workflows/python-app.yml Updates CI to use Python 3.14 and prek

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Comment thread README.md Outdated
@qartik qartik requested a review from Copilot December 16, 2025 22:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .pre-commit-config.yaml
rev: v0.14.9
hooks:
- id: ruff
- id: ruff-check
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook ID has changed from 'ruff' to 'ruff-check'. Verify that this is the correct hook ID for the version of ruff-pre-commit being used (v0.14.9), as this may break pre-commit functionality if the hook ID doesn't exist in that version.

Suggested change
- id: ruff-check
- id: ruff

Copilot uses AI. Check for mistakes.
@NathanCQC
Copy link
Copy Markdown
Collaborator

Niiice, I have been waiting for this.

What about this?

https://foundry.fsky.io/vel/ty-pre-commit

@qartik
Copy link
Copy Markdown
Member Author

qartik commented Dec 17, 2025

What about this?

foundry.fsky.io/vel/ty-pre-commit

I did notice it, but I am willing to wait for an official (more stable) release, see astral-sh/ty#269

@NathanCQC
Copy link
Copy Markdown
Collaborator

Ok, sounds good! Please merge when ready.

@qartik qartik added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit 9fe70f6 Dec 17, 2025
1 check passed
@qartik qartik deleted the chore-deps branch February 2, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider switching to mypy

3 participants