test: cover dynamic validation mutation survivors#80
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage for malformed dynamic runtime function declarations and tightens boundary testing around dynamic result-array output validation, with accompanying contributor guidance for future validation-signature work.
Changes:
- Added table-driven negative tests covering malformed dynamic RT signatures (allocate/release, array allocate/release, result-array record output).
- Added a positive boundary test asserting
i32::MAXlength is accepted for__quantum__rt__result_array_record_output. - Updated
AGENTS.mdto document expectations for negative signature tests, numeric boundary coverage, and scoped mutation runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/lib.rs |
Adds new validation regression tests for malformed dynamic RT declarations and the i32::MAX result-array output boundary. |
AGENTS.md |
Updates contributor guidance to ensure future signature-validation changes include robust negative/boundary/mutation coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i32::MAXboundary case for result array output validation.AGENTS.mdguidance so future validation-signature work uses table-driven negative tests, accepted/rejected numeric boundaries, and scoped mutation checks.Validation
cargo test --lib malformed_dynamiccargo test --lib test_validate_dynamic_result_array_record_output_i32_max_length_succeedscargo mutants --package qir-qis --all-features --test-tool cargo --file src/lib.rs --re 'src/lib\\.rs:.*(aux::is_i64_type|aux::is_ptr_return|aux::validate_dynamic_rt_signature|aux::validate_dynamic_array_allocation_backing)'make lintmake test