test: cover exact module flag diagnostics - #84
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves QIR module-flag validation diagnostics and adds a regression test to ensure unsupported dynamic_qubit_management flag values produce the expected “one of …” diagnostic, addressing a missed cargo-mutants case in aux::validate_exact_module_flag.
Changes:
- Simplified
validate_exact_module_flagto always format expected values using the multi-value “one of …” form. - Added a regression test that feeds an invalidly-typed
dynamic_qubit_managementmodule flag value and asserts the exact expected diagnostic text.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dynamic_qubit_managementmodule flag diagnostics.Validation
cargo test test_validate_qir_reports_exact_expected_dynamic_module_flag_value --all-featurescargo mutants --package qir-qis --all-features --test-tool cargo --file src/lib.rs --re validate_exact_module_flagmake lintmake testThis addresses the latest scheduled
Robustnessfailure from run25661067525, wherecargo-mutantsreported one missed mutant inaux::validate_exact_module_flag.