Skip to content

test: cover exact module flag diagnostics - #84

Merged
qartik merged 1 commit into
mainfrom
codex-fix-weekly-robustness-module-flag
May 11, 2026
Merged

qartik merged 1 commit into
mainfrom
codex-fix-weekly-robustness-module-flag

Conversation

@qartik

@qartik qartik commented May 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a regression for unsupported dynamic_qubit_management module flag diagnostics.
  • Simplify exact module flag diagnostic formatting to the actual multi-value contract used by current validation.

Validation

  • cargo test test_validate_qir_reports_exact_expected_dynamic_module_flag_value --all-features
  • cargo mutants --package qir-qis --all-features --test-tool cargo --file src/lib.rs --re validate_exact_module_flag
  • make lint
  • make test

This addresses the latest scheduled Robustness failure from run 25661067525, where cargo-mutants reported one missed mutant in aux::validate_exact_module_flag.

Copilot AI review requested due to automatic review settings May 11, 2026 12:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves QIR module-flag validation diagnostics and adds a regression test to ensure unsupported dynamic_qubit_management flag values produce the expected “one of …” diagnostic, addressing a missed cargo-mutants case in aux::validate_exact_module_flag.

Changes:

  • Simplified validate_exact_module_flag to always format expected values using the multi-value “one of …” form.
  • Added a regression test that feeds an invalidly-typed dynamic_qubit_management module flag value and asserts the exact expected diagnostic text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qartik
qartik merged commit d3a9803 into main May 11, 2026
41 checks passed
@qartik
qartik deleted the codex-fix-weekly-robustness-module-flag branch May 11, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants