Feat: improve frontend#195
Conversation
philipp-seitz
force-pushed
the
feat/improve-nested
branch
from
9a54e98 to
90ddbe4
Compare
|
I added a first draft for the times I'm not entirely happy |
mwpb
left a comment
mwpb
left a comment
There was a problem hiding this comment.
I'll trust the JS part; some small comments on the Python that aren't vital.
| if not self._error_logs_path(node_location).exists(): | ||
| if self._error_path(node_location).exists(): | ||
| print(self._error_path(node_location)) | ||
| with open(self._error_path(node_location), "r") as fh: |
There was a problem hiding this comment.
Okay with this in the short-term, although I'd prefer in future that _error_path be the indicator of whether an error has occurred (and never have contents). In this direction, we should probably change to something like the following in future:-
- the executor handles error (and logs) redirection
- if the exit code is non-zero then it touches _error_path
- it pipes stderr to _error_logs_path
(Also there is an extra print on the line above...)
There was a problem hiding this comment.
Adgreed, I just noticed that some nodes didn't have their correct error message attached. I opened #201 to keep track of this
| if not node_def.exists(): | ||
| return None | ||
| since_epoch = node_def.stat().st_mtime | ||
| return datetime.fromtimestamp(since_epoch).strftime("%Y-%m-%d %H:%M:%S") |
There was a problem hiding this comment.
Slight preference for isoformat() here but not a big thing.
2 participants
This contains various quality of life improvements and bugfixes: