fix: environment variables#198
Merged
Merged
Conversation
philipp-seitz
approved these changes
Sep 16, 2025
Collaborator
philipp-seitz
left a comment
philipp-seitz
left a comment
There was a problem hiding this comment.
Did you check with multiple variables? -x is correct but potentially this needs to be similar to slurm, the refecen is -x "variable=value[,...]"
mwpb
force-pushed
the
test/env-vars-on-fugaku
branch
from
4f14fc3 to
dc37896
Compare
Collaborator
Author
|
Multiple env vars appears to work. |
Collaborator
Author
|
(As an aside, I think that there is still a case to be made for having the slurm, pbs and pjsub executors largely separate. Indeed a large part of the motivation of having them separate is that we don't need to keep all the other executors in our minds when making changes to a single one. Furthermore we can hedge our bets by making a separate psi/j executor also and if that becomes a standard we can just remove the others.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lower case x is required when setting the env vars for Spack at least.