Skip to content

fix: make copy of executor spec for each call #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwpb merged 2 commits into from
Sep 18, 2025
Merged

fix: make copy of executor spec for each call #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91a7f2d
Do not mutate executor.spec
mwpb Sep 16, 2025
7b95234
Add debugging
mwpb Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions tierkreis/tierkreis/controller/executor/hpc/hpc_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,31 +39,30 @@ def run_hpc_executor(
)
logger.info("START %s %s", launcher_name, worker_call_args_path)

spec = executor.spec.model_copy()
if executor.launchers_path:
executor.spec.command = (
f"cd {executor.launchers_path}/{launcher_name} && {executor.spec.command}"
)
spec.command = f"cd {executor.launchers_path}/{launcher_name} && {spec.command}"

executor.spec.command += " " + str(worker_call_args_path)
spec.command += " " + str(worker_call_args_path)
submission_cmd = [executor.command]
if executor.spec.output_path is None:
if spec.output_path is None:
submission_cmd += ["-o", str(executor.logs_path)]
else:
submission_cmd += ["-o", str(executor.spec.output_path)]
if executor.spec.error_path is None:
submission_cmd += ["-o", str(spec.output_path)]
if spec.error_path is None:
submission_cmd += ["-e", str(executor.errors_path)]
else:
submission_cmd += ["-e", str(executor.spec.error_path)]
if executor.spec.include_no_check_directory_flag:
submission_cmd += ["-e", str(spec.error_path)]
if spec.include_no_check_directory_flag:
submission_cmd += ["--no-check-directory"]

with NamedTemporaryFile(
mode="w+",
delete=True,
suffix=".sh",
prefix=f"{executor.spec.job_name}-",
prefix=f"{spec.job_name}-",
) as script_file:
generate_script(executor.script_fn, executor.spec, Path(script_file.name))
generate_script(executor.script_fn, spec, Path(script_file.name))
submission_cmd.append(script_file.name)

process = subprocess.run(
Expand Down
3 changes: 3 additions & 0 deletions tierkreis/tierkreis/controller/executor/hpc/pjsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ def generate_pjsub_script(spec: JobSpec) -> str:
lines.append("\n# --- User Command ---")
lines.append(spec.command)

with open("./script", "w+") as fh:
fh.write("\n".join(lines))

return "\n".join(lines)


Expand Down