Skip to content

feat: Improve pytket worker and docs#203

Merged
philipp-seitz merged 14 commits into
mainfrom
feat/pytket_worker
Sep 24, 2025
Merged

feat: Improve pytket worker and docs#203
philipp-seitz merged 14 commits into
mainfrom
feat/pytket_worker

Conversation

@philipp-seitz
Copy link
Copy Markdown
Collaborator

adds multiple tasks to the pytket worker and improves the docs on wokers

@philipp-seitz philipp-seitz requested a review from mwpb September 18, 2025 07:30
Copy link
Copy Markdown
Collaborator

@mwpb mwpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick comments on the draft.

Comment thread docs/source/worker/external_workers.md Outdated
Comment thread docs/source/worker/external_workers.md Outdated
Comment thread docs/source/worker/external_workers.md Outdated
Comment thread docs/source/worker/external_workers.md Outdated
Comment thread docs/source/worker/external_workers.md Outdated
Comment thread docs/source/workers.md Outdated
Comment thread docs/source/workers.md Outdated
Comment thread tierkreis_workers/pytket_worker/main.py
@philipp-seitz philipp-seitz marked this pull request as ready for review September 22, 2025 04:05
Comment thread tierkreis/tierkreis/controller/data/types.py Outdated
@philipp-seitz
Copy link
Copy Markdown
Collaborator Author

There is a type issue caused by the addition UnionType here
of the form "type[UnionType]" is not assignable to "type", which I think is a bug in pyright (see pyright#10823), should we ad an ignore statement?

Comment thread docs/source/worker/external_workers.md Outdated
Comment thread tierkreis/tierkreis/controller/data/types.py Outdated
@mwpb
Copy link
Copy Markdown
Collaborator

mwpb commented Sep 22, 2025

There is a type issue caused by the addition UnionType here of the form "type[UnionType]" is not assignable to "type", which I think is a bug in pyright (see pyright#10823), should we ad an ignore statement?

Yes, ran into this also in #207, which is still draft. Will try to have a workaround ready by the end of the day UK time.

@philipp-seitz philipp-seitz enabled auto-merge (squash) September 24, 2025 01:47
@philipp-seitz philipp-seitz requested a review from mwpb September 24, 2025 01:47
@philipp-seitz philipp-seitz merged commit 0314fdb into main Sep 24, 2025
6 checks passed
@philipp-seitz philipp-seitz deleted the feat/pytket_worker branch September 24, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants