Fix/pytket_worker#211
Merged
Merged
Conversation
Collaborator
Author
|
@mwpb should we care about the |
philipp-seitz
force-pushed
the
fix/pytket_worker
branch
from
09d4f45 to
2eb2dde
Compare
mwpb
approved these changes
Sep 30, 2025
Collaborator
mwpb
left a comment
mwpb
left a comment
There was a problem hiding this comment.
Seems reasonable, though I had some small questions.
| self.logs_path = workflow_dir / "logs" | ||
| self.errors_path = workflow_dir / "logs" | ||
| self.workflow_dir = workflow_dir | ||
| self.timeout = timeout |
Collaborator
There was a problem hiding this comment.
Is this still required now that we background the command?
| try: | ||
| from pytket.qir.conversion.api import pytket_to_qir | ||
| except ModuleNotFoundError: | ||
| raise TierkreisError("Could not resolve pytket.qir") |
Collaborator
There was a problem hiding this comment.
Hmm... do we specifically handle TierkreisError somewhere? If not then I wonder how much information this error message is adding?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some QOL/fixes to interact better with the pytket worker