feat: Allow modifier use with qis-compiler#1451
Open
jake-arkinstall wants to merge 1 commit intomainfrom
Open
Conversation
… - add python tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1451 +/- ##
=======================================
Coverage 79.60% 79.60%
=======================================
Files 155 155
Lines 20335 20335
Branches 19345 19345
=======================================
Hits 16187 16187
Misses 3188 3188
Partials 960 960
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
We decided to have the users call the pass explicitly instead, while this remains experimental. Note that the pass is not yet exposed from python. See #1452 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, the use of (experimental?) guppylang modifiers, such as:
Results in
This PR adds use of the
ModifierResolverPassbefore QSystemPass to resolve modifiers, enabling compilation to QIS.