fix: bug in hugr building when control modifiers are nested#1550
Draft
nicolaassolini-qntm wants to merge 62 commits intomainfrom
Draft
fix: bug in hugr building when control modifiers are nested#1550nicolaassolini-qntm wants to merge 62 commits intomainfrom
control modifiers are nested#1550nicolaassolini-qntm wants to merge 62 commits intomainfrom
Conversation
…ance result handling
…nhance testing pipeline
…ple script for modifier testing
… double_modifier.py, update rendering, and improve apply_passes.py logic
…and update justfile for hugr compilation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…_saved_hugr Co-authored-by: Copilot <copilot@github.com>
…for processing hugrs Co-authored-by: Copilot <copilot@github.com>
…odifier examples Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…rs for validation and fix doc indentation Co-authored-by: Copilot <copilot@github.com>
…structs to private Co-authored-by: Copilot <copilot@github.com>
…_modifier_with_entrypoints function
…fix-multiple-controller-bug
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
+ Coverage 83.80% 84.03% +0.22%
==========================================
Files 188 188
Lines 29035 29101 +66
Branches 27931 27997 +66
==========================================
+ Hits 24334 24455 +121
+ Misses 3539 3473 -66
- Partials 1162 1173 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…nd related scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1537
The bug was in
modify_signature: it prepended each accumulated control array with repeated insert(0, ...), which reversed nested control groups. For accumulated controls like [2, 1], the function signature became [array(1), array(2), ...] while the caller and generated unpack nodes expected [array(2), array(1), ...].I changed it to build the full control prefix once and splice it at the front, preserving accumulation order.