Skip to content

feat: Clean Up by Deleting Unconnected Nodes after Modifier Solve #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicolaassolini-qntm wants to merge 46 commits into
base: main
Choose a base branch
from

Remove redundant check for linked inputs before removing target node …

59f5f40
Select commit
Loading
Failed to load commit list.
Draft

feat: Clean Up by Deleting Unconnected Nodes after Modifier Solve #1557

Remove redundant check for linked inputs before removing target node …
59f5f40
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 29, 2026 in 0s

84.03% (+0.22%) compared to 6d87034

View this Pull Request on Codecov

84.03% (+0.22%) compared to 6d87034

Details

Codecov Report

❌ Patch coverage is 79.46429% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.03%. Comparing base (6d87034) to head (59f5f40).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tket/src/modifier/modifier_resolver/call_modify.rs 73.17% 9 Missing and 2 partials ⚠️
tket/src/modifier/modifier_resolver.rs 84.21% 2 Missing and 7 partials ⚠️
tket/src/modifier/control.rs 50.00% 1 Missing ⚠️
tket/src/modifier/dagger.rs 50.00% 1 Missing ⚠️
tket/src/modifier/power.rs 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
+ Coverage   83.80%   84.03%   +0.22%     
==========================================
  Files         188      188              
  Lines       29035    29102      +67     
  Branches    27931    27998      +67     
==========================================
+ Hits        24333    24456     +123     
+ Misses       3540     3473      -67     
- Partials     1162     1173      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov