Conversation
index.css imports @fontsource-variable/public-sans, which registers the family 'Public Sans Variable'. theme.css asked for 'Public Sans', which no @font-face declares, so the sans font axis rendered in the browser's generic sans-serif. List the variable family first, the same pattern as --font-serif ('Lora Variable', 'Lora', ...), and keep 'Public Sans' for a locally installed static copy. The test reads the family registered by the imported @fontsource package and checks that --font-sans lists it first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011NzqVZFqhT96S2aF7182nP
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. WalkthroughThe sans font stack now tries the bundled Public Sans Variable family before its existing fallbacks. A test checks that the stack starts with the family registered by the imported sans package. ChangesSans font family
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The UI should use the bundled Public Sans Variable font. No actionable merge risk remains after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit found the font by name, Comment |
Agent
Links
web/defaultfonts.css)User request
Prompt
Out of scope — refuse
Open gate — do not open unless all are satisfied
go buildor tests passed: yesKind
Issue facts
--font-sansnamesPublic Sans, but@fontsource-variable/public-sansregistersPublic Sans Variable, so the UI renders in the system sans-serifweb/src/styles/theme.cssline 22 against the family the imported package registers/and/sign-in, Chromium 141, light theme, no font console errors. Relay, billing, deployment: not applicableChange
--font-sans: 'Public Sans Variable', 'Public Sans', sans-serif;, the same pattern as--font-serif. The other places that name Public Sans (index.css,theme-presets.css,theme-customization.ts) need no change. A test reads the family name from the package's CSS and checks that--font-sanslists it first.Research
Duplicate / prior art
Public Sans,Public Sans Variable,font-sans,fontsourceweb/defaultfonts.css, not this family nameDocs and code
web/AGENTS.mdindex.cssimports the package;theme.csssets the token;--font-serifalready lists'Lora Variable'firstAlternatives considered
@fontsource-variable/public-sansimport and keep the system font. Changes the intended design.Files
web/src/styles/theme.css--font-sansweb/src/styles/__tests__/font-sans.test.tsBehavior
var(--font-sans)has the same width as genericsans-serifPublic Sans Variableloads and is usedpublic-sans-latin-wght-normal.woff2(26,832 bytes)Verification
web/):expected 'Public Sans' to be 'Public Sans Variable'bun run typecheck: exit 0oxlinton the changed files: 0 errorsbun run test: 167 files, 2112 tests passedbun run build: exit 0/: on main no web font is loaded and a 40 px test string invar(--font-sans)is 535.94 px wide, the same as genericsans-serif; with the fixPublic Sans Variableloads on its own and the string is 569.86 px, the same as'Public Sans Variable'font-sans.test.tsRisks
sans-serifas todayScope check
This change was AI-generated (Claude Code) and reviewed by the submitter.
Summary by CodeRabbit