-
-
Notifications
You must be signed in to change notification settings - Fork 32
Named command args #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Named command args #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bb686a
to
2ba27c0
Compare
ready once #277 is merged |
6a6c6eb
to
3f0f843
Compare
6 tasks
3f0f843
to
2d203a5
Compare
61bdb0c
to
0eb286a
Compare
rebased, ready for review |
ix0rai
reviewed
Sep 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful! i love how this fits into the old structure of command classes, and all the testing is great! just a couple issues with the messages and nitpicks.
enigma-cli/src/main/java/org/quiltmc/enigma/command/Command.java
Outdated
Show resolved
Hide resolved
enigma-cli/src/main/java/org/quiltmc/enigma/command/Command.java
Outdated
Show resolved
Hide resolved
enigma-cli/src/main/java/org/quiltmc/enigma/command/Command.java
Outdated
Show resolved
Hide resolved
enigma-cli/src/main/java/org/quiltmc/enigma/command/DecompileCommand.java
Show resolved
Hide resolved
Co-authored-by: ix0rai <[email protected]>
Co-authored-by: ix0rai <[email protected]>
ix0rai
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #277rebasedAllows use of named args of the form
some-name=some-value
.Particularly useful for commands with many optional args.
Unnamed positional arguments may still be used, even at the same time as named args, so long as all positional args come before named args.
Centralizes parsing of individual args into
Argument
and of commands' accepted args intoArgsParser
.Additionally, makes path verification more consistent and fixes the following bugs:
InvertMappingsCommand
usedOUTPUT_FOLDER
instead ofMAPPING_OUTPUT
InvertMappingsCommand
args skipped an indexDecompileCommand
usedgetWritableFolder
forOUTPUT_JAR
ENIGMA_PROFILE
didn't verify it was a fileComposeMappingsCommand
didn't declare its optional de/obf args