Dispel magic! #8
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates automatic installation of components and listeners and generally tries to reduce the amount of "magical" side-effects-based behavior.
This makes things more customizable and easier to follow.
Can be tested by publishing locally and checking out QuiltMC/enigma#317
Remaining magic:
JavaLexer: it's generated by jflex; that's just fundamentally how it worksJavaSyntaxKitis still installed to make editors useSyntaxViews andSyntaxDocuments;AFAICT there's no way to manually attach a different
ViewFactoryto an editor without completely replacing itsTextUIwhich would also replace all the functionality of the UI installed by flatlaf.Also:
LineNumbersRuler's numbers (for use in tooltip snippets)SyntaxpainConfigurationbut addsJavaSyntaxKit::setSyntaxColorsforSyntaxStyle; keeping this is necessary becauseJavaSyntaxKitis still magical