New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make partition_types::Type::FromStr case-insensitive for guid #104

Merged

soerenmeier merged 1 commit into Quyzi:master from IronBatman2715:caseinsensitve-partitontypeguid

Sep 13, 2024

Contributor

IronBatman2715 commented Sep 2, 2024 •

edited

Loading

This does make Type::from_name() kind of redundant. Since now the input will be uppercased twice.

Could remove uppercase call in from_name(), but not sure how you want to handle that change from a logging perspective.


          Make partition_types::Type::FromStr case-insensitive for guid

6822f6e

Collaborator

soerenmeier commented Sep 13, 2024

Looks good thanks, will remove the to_uppercase and the trace. don't think it's that particularly useful.

soerenmeier merged commit 2341e2c into Quyzi:master

8 checks passed

IronBatman2715 deleted the caseinsensitve-partitontypeguid branch

September 13, 2024 22:11

IronBatman2715 restored the caseinsensitve-partitontypeguid branch

September 13, 2024 22:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet