fix: standardise error handling

[DustinJSilk]

What is it?

• Bug

Description

This fixes a few issues with server$ error handling

• 4xx ServerErrors are returning a a value instead of throwing an error on the frontend
• server$ middleware could not catch errors - the server$ function would simply exit early. [🐞] server$ middleware cannot catch errors #7183
• You can now also throw a ServerError in a routeLoader$ to change the status code and return some serialised data. This is simply an added bonus but should pave the way for more standardised errors across loaders, actions, and server$ functions

Checklist

• My code follows the developer guidelines of this project
• I performed a self-review of my own code
• I added a changeset with pnpm change
• I made corresponding changes to the Qwik docs
• I added new tests to cover the fix / functionality

[changeset-bot]

🦋 Changeset detected

Latest commit: 9277e31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@builder.io/qwik-city	Minor
eslint-plugin-qwik	Minor
@builder.io/qwik	Minor
create-qwik	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[DustinJSilk]

I get this error when running pnpm change: Failed to find where HEAD diverged from origin/upcoming. Does origin/upcoming exist?

[DustinJSilk]

I would add a fix for this: #7165, but i have no idea how to fix it.

[DustinJSilk]

@wmertens fyi - returning errors as values was intentional in this PR: #6290.
I dont think this was the right decision, as it becomes really difficult to work with. Now, errors behave like javascript errors and the user can catch them and use a type guard on the data instead.

[DustinJSilk]

@shairez any chance we can get this PR reviewed?

[wmertens]

for the origin/upcoming, try git fetch origin upcoming.

So if I understand correctly, the only somewhat breaking change is that 4xx errors now throw on the client side, right? That seems more like a bugfix than a breaking change.

[DustinJSilk]

Thanks @wmertens !

Yes, the only breaking change is that 4xx errors now throw on the client. It should be classified as a bug fix.

I've added a changeset now, I had to temporarily change the changset config "baseBranch": "origin/upcoming", to "baseBranch": "upcoming", to get it to work

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7185

npm i https://pkg.pr.new/@builder.io/qwik-city@7185

npm i https://pkg.pr.new/eslint-plugin-qwik@7185

npm i https://pkg.pr.new/create-qwik@7185

commit: 9277e31

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	9277e31

[shairez]

great job Dustin!

[wmertens]

Looks great, just two small things

[DustinJSilk]

Thanks @wmertens and @shairez!

[DustinJSilk]

Gentle nudge @wmertens

[wmertens]

[DustinJSilk]

@shairez can you merge these changes please

[shairez]

Thanks again @DustinJSilk ! great job!

[DustinJSilk]

Thanks both!