Skip to content

fix: RequestEventAction has missed a type resolveValue #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

fix: RequestEventAction has missed a type resolveValue #7378

wants to merge 26 commits into from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Feb 25, 2025 •
edited
Loading

What is it?

fixes #7377

if routeAction$ wants to use resolveValue function，routeLoader$ has be loaded first,
so I move the routerLoader logic before method === 'POST', However, in some situations, it has to remain in its original position.

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner February 25, 2025 05:09
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 88f268c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JerryWu1234 JerryWu1234 requested review from a team as code owners February 25, 2025 06:03
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 25, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7378

npm i https://pkg.pr.new/@builder.io/qwik-city@7378

npm i https://pkg.pr.new/eslint-plugin-qwik@7378

npm i https://pkg.pr.new/create-qwik@7378

commit: 88f268c

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 88f268c

@wmertens
Copy link
Member

the problem is that the resolveValue is not actually working even though it's documented. So this PR needs to implement it too.

@JerryWu1234
Copy link
Contributor Author

JerryWu1234 commented Mar 1, 2025 •
edited
Loading

the problem is that the resolveValue is not actually working even though it's documented. So this PR needs to implement it too.

@wmertens
Is there a code reference I could follow ?

@wmertens
Copy link
Member

wmertens commented Mar 1, 2025

@JerryWu1234 best to search the code for resolveValue and see how it is implemented, and then try to implement it in the same way in the other locations.

@JerryWu1234 JerryWu1234 marked this pull request as draft March 2, 2025 12:54
@JerryWu1234 JerryWu1234 self-assigned this Mar 11, 2025
@JerryWu1234 JerryWu1234 marked this pull request as ready for review March 11, 2025 06:08
@JerryWu1234
Copy link
Contributor Author

@JerryWu1234 best to search the code for resolveValue and see how it is implemented, and then try to implement it in the same way in the other locations.

thanks for your tips, it's useful

@shairez shairez moved this from Backlog to Waiting For Review in Qwik Development Mar 11, 2025
@shairez shairez moved this from Waiting For Review to In progress in Qwik Development Mar 11, 2025
@JerryWu1234 JerryWu1234 marked this pull request as draft March 12, 2025 09:48
@JerryWu1234 JerryWu1234 marked this pull request as ready for review March 13, 2025 03:26
@JerryWu1234 JerryWu1234 moved this from In progress to Waiting For Review in Qwik Development Apr 11, 2025
@JerryWu1234
Copy link
Contributor Author

@wmertens @Varixo please help to review it when you are available

gioboa
gioboa requested changes May 2, 2025
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JerryWu1234 for your help 🎉
I added few comments

packages/qwik-city/src/middleware/request-handler/resolve-request-handlers.ts
}
isAction = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to reset it to false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to prevent it from running multiple times.

wmertens
wmertens requested changes May 6, 2025
View reviewed changes
@JerryWu1234
fix(qwik-city): add type for routeAction$'s `requestEvent.resolveVa…
e0991b8 
…lue`

refactor(qwik-city): simplify loader function in actionsMiddleware
perf(qwik-city): freeze request event object to prevent mutations
feat(qwik): add platform-specific bindings for darwin-arm64, win32-x64, and linux-x64
Varixo
Varixo reviewed May 8, 2025
View reviewed changes
@JerryWu1234
docs(changeset): remove '@builder.io/qwik' from patch list
88f268c 
The '@builder.io/qwik' package was mistakenly included in the patch list. This commit removes it to ensure the changeset accurately reflects the intended scope of the update.
@maiieul maiieul added WAITING FOR: team Waiting for one of the core team members to review and reply STATUS-2: requires discussion Requires further discussion before moving forward labels May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Varixo Varixo Varixo left review comments

@wmertens wmertens wmertens requested changes

@gioboa gioboa gioboa requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@JerryWu1234 JerryWu1234

Labels
STATUS-2: requires discussion Requires further discussion before moving forward WAITING FOR: team Waiting for one of the core team members to review and reply
Projects
Qwik Development
Status: Waiting For Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] "resolveValue" Function Is Missing in TypeScript Types and Fails in "routeAction$" / "globalAction$"
5 participants
@JerryWu1234 @wmertens @gioboa @Varixo @maiieul