Don't crash in calc_AverageDose() on some RLum.Results objects #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RLum.Results object generated by calc_AverageDose() has only one row, and R returns its standard deviation as NA. In this case, we reset it to 0 and carry on. However, with just one value, also the breaks argument of hist() needs to be manually set to avoid an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RLum.Resultsobject generated bycalc_AverageDose()has only one row, and R returns its standard deviation asNA. In this case, we reset it to 0 and carry on. However, with just one value, also thebreaksargument ofhist()needs to be manually set to avoid an error.Fixes #285. Additionally, it adds a snapshot test (part of #243).