Tighten checks on inputs and consolidate code in calc_CosmicDoseRate() #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in the two if blocks is effectively the same, as if length(depth) = 1 then it must be that also length(density) = 1, so it's true that both depth and density have the same length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #595 and adds some more validation of inputs to cover other corner cases.
The code for the case in which
length(depth) == 1can be removed because after validation it must be that alsolength(density) == 1: note that the computation done in that block is undone and then recomputed in the second block, as it's also true thatlength(depth) == length(density). So we may as well just use the code in the second block in both cases.