CON-1187: Fix QA tests, fix enclave constraint in release mode for CordApp test #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsasari
reviewed
Nov 4, 2022
| } | ||
| return NON_MOCK_CONSTRAINT + " " + securitySuffix; | ||
| } | ||
| return MOCK_CONSTRAINT; |
shamsasari
reviewed
Nov 4, 2022
| // DO NOT BLINDLY COPY PASTE THIS. The SEC:INSECURE part does what it sounds like: turns off security for convenience | ||
| // when unit testing and developing. | ||
| // | ||
| // Obviously in a real app you'd not use SEC:INSECURE, however this makes the sample work in simulation mode. |
There was a problem hiding this comment.
This comment is now out of date
bon000
commented
Nov 4, 2022
| return mock_constraint; | ||
| String mode = System.getProperty("enclaveMode").toLowerCase(); | ||
|
|
||
| if (mode == null || !mode.toLowerCase().equals("mock")) { |
There was a problem hiding this comment.
This is also buggy. Will fix on Monday. But I can't get an environment setup for this test in 1.8, this is a real concern.
|
I don't think this PR is needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.