1925 support for questionnaire validation and field requirements#1927
Merged
mpgxvii merged 7 commits intoMay 24, 2026
Merged
Conversation
mpgxvii
reviewed
Apr 28, 2026
mpgxvii
reviewed
Apr 28, 2026
Member
There was a problem hiding this comment.
This might need updating to validationType to keep the support for the date/time validation?
Member
|
Thanks for this @ec18130! I've added initial comments. |
mpgxvii
reviewed
May 5, 2026
mpgxvii
requested changes
May 12, 2026
Member
mpgxvii
left a comment
There was a problem hiding this comment.
Nice! Just a few more suggestions then we can merge.
…utton and changed the way free text number validation works
…paulines comments
5484c9b to
76a61d3
Compare
mpgxvii
approved these changes
May 24, 2026
Member
mpgxvii
left a comment
There was a problem hiding this comment.
Great! Thanks for the changes. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable specific input types for text fields based on validation metadata.
Attribute: "text_validation_type_or_show_slider_number": "number"
Action: When this is set to "number", the input field should restrict entry to numeric values and trigger the numeric keypad on mobile devices.