Skip to content

1925 support for questionnaire validation and field requirements#1927

Merged
mpgxvii merged 7 commits into
devfrom
1925-Support-for-questionnaire-validation-and-field-requirements
May 24, 2026
Merged

1925 support for questionnaire validation and field requirements#1927
mpgxvii merged 7 commits into
devfrom
1925-Support-for-questionnaire-validation-and-field-requirements

Conversation

@ec18130
Copy link
Copy Markdown
Contributor

@ec18130 ec18130 commented Apr 27, 2026

Enable specific input types for text fields based on validation metadata.

Attribute: "text_validation_type_or_show_slider_number": "number"
Action: When this is set to "number", the input field should restrict entry to numeric values and trigger the numeric keypad on mobile devices.

Comment thread src/app/pages/questions/components/question/text-input/text-input.component.ts Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need updating to validationType to keep the support for the date/time validation?

@mpgxvii
Copy link
Copy Markdown
Member

mpgxvii commented Apr 28, 2026

Thanks for this @ec18130! I've added initial comments.

Comment thread src/app/pages/questions/components/question/text-input/text-input.component.ts Outdated
@mpgxvii mpgxvii marked this pull request as ready for review May 12, 2026 20:22
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. feature javascript Pull requests that update Javascript code labels May 12, 2026
Copy link
Copy Markdown
Member

@mpgxvii mpgxvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few more suggestions then we can merge.

Comment thread src/app/pages/questions/components/question/text-input/text-input.component.ts Outdated
Comment thread src/app/pages/questions/services/questions.service.ts Outdated
Comment thread src/app/pages/questions/containers/questions-page.component.html Outdated
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 18, 2026
@ec18130 ec18130 force-pushed the 1925-Support-for-questionnaire-validation-and-field-requirements branch from 5484c9b to 76a61d3 Compare May 18, 2026 13:54
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels May 18, 2026
@ec18130 ec18130 requested a review from mpgxvii May 21, 2026 10:30
Copy link
Copy Markdown
Member

@mpgxvii mpgxvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the changes. LGTM!

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 24, 2026
@mpgxvii mpgxvii merged commit 1a3dbe1 into dev May 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants