Skip to content

fix: Version display shows v? in dev builds #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RAKKUNN merged 1 commit into from
Apr 12, 2026
Merged

fix: Version display shows v? in dev builds #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion DualClip/Views/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,25 @@ struct SettingsView: View {
.frame(width: 420, height: 320)
}

/// Resolve app version: Bundle (release .app) → source Info.plist (dev swift run)
private static var appVersion: String {
// 1. Try Bundle.main (works in .app bundles)
if let version = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String {
return version
}
// 2. Fallback: read from source Info.plist (works with swift run)
if let plistPath = Bundle.main.executableURL?
.deletingLastPathComponent() // .build/debug/
.deletingLastPathComponent() // .build/
.deletingLastPathComponent() // project root
.appendingPathComponent("DualClip/Info.plist"),
let dict = NSDictionary(contentsOf: plistPath),
let version = dict["CFBundleShortVersionString"] as? String {
return version
}
return "dev"
}

// MARK: - Shortcuts Tab

private var shortcutsTab: some View {
Expand Down Expand Up @@ -65,7 +84,7 @@ struct SettingsView: View {
.font(.callout)
.foregroundColor(.secondary)

Text("v\(Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ?? "?")")
Text("v\(Self.appVersion)")
.font(.caption)
.foregroundColor(.secondary)

Expand Down
Loading