tests/{core,cpu,drivers}: use SPDX copyright tags #21896
Merged
+520
−1,240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
requested review from
MichelRottleuthner,
aabadie,
jeandudey and
leandrolanzieri
as code owners
maribu
force-pushed
the
tests/c_d/spdx
branch
from
34abac8 to
4094dae
Compare
AnnsAnns
requested changes
Nov 19, 2025
Member
|
The rest looked fine :) |
AnnsAnns
approved these changes
Nov 19, 2025
AnnsAnns
added
the
CI: ready for build
Member
|
Thank you |
maribu
force-pushed
the
tests/c_d/spdx
branch
from
8e1fc5f to
b1b942f
Compare
maribu
added
the
Impact: minor
Member
Author
|
Thx ❤️ |
crasbe
added
the
Type: cleanup
crasbe
reviewed
Nov 19, 2025
| * All Rights Reserved. | ||
| * See: https://www.riot-os.org/branding.html | ||
| * | ||
| * SPDX-FileCopyrightText: 2013 RIOT OS, All Rights Reserved. |
Contributor
There was a problem hiding this comment.
I would've removed the All Rights Reserved. here, that's not an author.
Member
Author
There was a problem hiding this comment.
It doesn't need to be an author, the definition and practical usage in other people's code does not limit it to listing authors and years only.
Dropping the All Rights Reserved here would only cause confusion, as there is no license specified. And SPDX did not add a license identifier for "All Rights Reserved" (yet), so that has to go somewhere.
| * All Rights Reserved. | ||
| * See: https://www.riot-os.org/branding.html | ||
| * | ||
| * SPDX-FileCopyrightText: 2013 RIOT OS, All Rights Reserved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
As the title says
Testing procedure
The CI should run super fast if it can determine that changes are whitespace only. This should be the case here.
In addition, the diff should be checked for correctness.
Issues/PRs references
#21515