Skip to content

Consumer graph drift check fails repo-wide: kfdtest edges missing from committed graph #7298

Closed

Description

@BrianHarrisonAMD

Summary

test_tools/therock_consumer_graph.json is missing the kfdtest edges. The drift check compares the whole file, so this affects every PR that touches a graph-affecting path.

Possible fix: #7297.

Details

kfdtest was added as a subproject in #6334. The drift check landed three days before it merged (#6941), so the check was new and its reviewers were not looking for it. It ran on #6334 and failed with these edges, but it is not part of the CI Summary gate, so it did not block the merge.

Since the comparison is whole-file, a PR cannot regenerate only its own edges. It either fails the check or commits the 10 kfdtest lines alongside unrelated work. Recent examples: users/PeterCDMcLean/meson-version-script-per-target, users/marifamd/rocm-smi-disable, users/lakshmi/windows-mesa-updates, users/adam360x/sysdeps-libfwupd. Open PRs carrying the lines: #7166, #7288, #6922.

users/stella/hotswap-pre-cache shows a second set accumulating for rccl-translate.

Proposed actions

  1. Land fix(ci): regenerate consumer graph for kfdtest edges #7297 so the edges are attributed to kfdtest and reviewed by its owners.
  2. Decide whether the drift check should gate merge, or document it as advisory.

Scope

Regenerating does not change behavior. Selection can emit kfdtest, but there is no kfdtest key in fetch_test_configurations.py, so no job is scheduled. Adding one belongs with the kfdtest and rocr-runtime owners.

cc @andmar-amd @nunnikri @ScottTodd @endurthiabhilash

Activity

  1. BrianHarrisonAMD commented on Aug 12, 2026

    @BrianHarrisonAMD
    ContributorAuthor

    Splitting this out of #7166 so the edges are reviewed by the kfdtest owners rather than riding along in an ml-libs change.

    #7297 needs to land first, otherwise #7166 and the other graph-touching PRs keep failing the drift check.

  2. BrianHarrisonAMD commented on Aug 12, 2026

    @BrianHarrisonAMD
    ContributorAuthor

    Closing for now, regeneration PR has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

CICDRelated to CI/CD Infrainfraissue related to infrastructure

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions