Repository navigation
build: wire TEST_SUBPROJECTS for P1 rocm-sytems components - #6703
endurthiabhilash wants to merge 1 commit into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
| TEST_SUBPROJECTS | ||
| amd-dbgapi | ||
| aqlprofile | ||
| composable_kernel | ||
| hip-clr | ||
| hipBLAS | ||
| hipBLASLt | ||
| hipDNN | ||
| hipDNN_samples | ||
| hipFFT | ||
| hipRAND | ||
| hipblasltprovider | ||
| hipdnn_integration_tests | ||
| hipkernelprovider | ||
| libhipcxx | ||
| MIOpen | ||
| miopenprovider | ||
| ocl-clr | ||
| ocl-icd | ||
| rccl | ||
| rocdecode | ||
| rocjpeg | ||
| rocBLAS | ||
| rocFFT | ||
| rocPRIM | ||
| rocRAND | ||
| rocWMMA | ||
| rocgdb | ||
| rocprofiler-sdk | ||
| rocr-debug-agent | ||
| rocr-debug-agent-tests | ||
| rocrtst | ||
| rocshmem | ||
| ) |
There was a problem hiding this comment.
Same feedback as on #6646
Please do this the right way. The build system already has this "depends on" data, and maintaining a manual list this long is untenable. We also have an RFC for moving subproject CMake declarations out of TheRock and next to their source code: https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0003-Build-Tree-Normalization.md, at which point there will be no reliable way to have a project in rocm-systems declare that some projects in another repository (e.g. rocm-libraries) depend on it and should run their tests on changes.
There was a problem hiding this comment.
Ack, agree that the list is long, especially for components like rocr-runtime, hip-clr. @geomin12 and I can look into dynamically getting the dependent project data.
Add TEST_SUBPROJECTS entries to therock_cmake_subproject_declare blocks: - amdsmi: hipBLAS, hipBLASLt, rocBLAS, rccl, rdc, rocprofiler-systems, rocrtst - hip-clr: composable_kernel, hip-tests, hipBLAS, hipBLASLt, hipDNN, hipDNN_samples, hipFFT, hipInfo, hipRAND, hipblasltprovider, hipdnn_integration_tests, hipkernelprovider, libhipcxx, MIOpen, miopenprovider, rccl, rdc, rocdecode, rocjpeg, rocBLAS, rocFFT, rocPRIM, rocRAND, rocWMMA, rocprofiler-systems, rocr-debug-agent-tests, rocshmem, therock-wsl-rocdxg - ROCR-Runtime: amd-dbgapi, aqlprofile, composable_kernel, hip-clr, hipBLAS, hipBLASLt, hipDNN, hipDNN_samples, hipFFT, hipRAND, hipblasltprovider, hipdnn_integration_tests, hipkernelprovider, libhipcxx, MIOpen, miopenprovider, ocl-clr, ocl-icd, rccl, rocdecode, rocjpeg, rocBLAS, rocFFT, rocPRIM, rocRAND, rocWMMA, rocgdb, rocprofiler-sdk, rocr-debug-agent, rocr-debug-agent-tests, rocrtst, rocshmem - rocprofiler-sdk: hipBLAS, hipBLASLt, hipFFT, MIOpen, rccl, rdc, rocBLAS, rocFFT, rocprofiler-compute, rocprofiler-systems Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
1746ce8 to
6f65638
Compare
geomin12
left a comment
geomin12
left a comment
There was a problem hiding this comment.
as mentioned here (#6646 (comment)), this is not an ideal solution. However, this is a replicate of therock-matrix.py and this will apply to multi-arch.
After multi-arch migration happens, @endurthiabhilash and I are going to work to improve this retrieval to be dynamic. Especially if https://github.com/ROCm/TheRock/blob/main/docs/rfcs/RFC0003-Build-Tree-Normalization.md occurs, we want our solution to be workable for both CMakeLists scenarios
| MIOpen | ||
| miopenprovider | ||
| ocl-clr | ||
| ocl-icd |
There was a problem hiding this comment.
last i checked, we don't run this FYI. can be removed
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
Well, I tried asking nicely multiple times but now I'll request changes. Do this the right way. Not going to approve explicit lists this long for all projects.
|
I'm working on a redesign as requested, will create a PR once ready for review. |
|
No longer needed as #6941 dynamically selects sub projects. |
3 participants
As part of enabling multi-arch on rocm-libraries #3343, adding TEST_SUBPROJECTS entries to therock_cmake_subproject_declare blocks so downstream consumers are tracked for testing:
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist