hipthreads: Disable hipthreads failures blocked by Compiler ww28 SMP 2.5 - #7158
Draft
lajagapp wants to merge 1 commit into
Draft
hipthreads: Disable hipthreads failures blocked by Compiler ww28 SMP 2.5#7158lajagapp wants to merge 1 commit into
lajagapp wants to merge 1 commit into
Conversation
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
lajagapp
force-pushed
the
users/lajagapp/disable-hipthread-test
branch
from
August 6, 2026 17:06
90ae4d7 to
1db049f
Compare
ronlieb
approved these changes
Aug 6, 2026
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily excludes
hipthreadsfailures that block the Compiler ww28 SMP 2.5 promotion in TheRock#7052 (amd-llvm7287e2062fa6). Linux and Windows jobs fail for unrelated reasons, so each uses the mechanism that matches its failure mode.Tracked by #7157.
Changes
test_hipthreads.pyexcludescreate_late.pass.cppon Linux,fetch_test_configurations.pymarks the Windows hipthreads job as expected-failure, andtests/fetch_test_configurations_test.pycovers the new matrix field.Linux
create_late.pass.cppis marked upstream as "expected to fail", but it passes with the new compiler, and lit fails the run on that unexpected pass. It is the only test that changed out of 384.It is skipped with lit
--filter-out. The alternative,--xfail-not, would breakmain, where the old compiler still makes the test fail as expected.Windows
lit builds a small compiler-check program before running anything, and that build now fails at link time (
lld-link: error: relocation against symbol in discarded section: __start_llvm_offload_entries). No tests run at all, so there is nothing to skip and the whole job is marked as expected to fail.The xfail comes from a new
expect_failure_platformfield on the hipthreads matrix entry rather than a hardcoded check in the job loop, following the existingexclude_familystyle.Related