Skip to content

fix(rocprofiler-systems): Set SYS_PTRACE and PERFMON capabilities when running tests - #7163

Draft
kcossett-amd wants to merge 1 commit into
mainfrom
users/kcossett-amd/add-cap-sys
Draft

fix(rocprofiler-systems): Set SYS_PTRACE and PERFMON capabilities when running tests#7163
kcossett-amd wants to merge 1 commit into
mainfrom
users/kcossett-amd/add-cap-sys

Conversation

@kcossett-amd

@kcossett-amd kcossett-amd commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

JIRA ID: AIPROFSYST-720

Some tests in our test suite require certain capabilities for them to be run. Of particular concern are the attach tests, which require SYS_PTRACE to run (matches rocprofiler-SDK).

I will also add PERFMON as some of our other tests (annotate, overflow...) require this as well.

None of these tests will run yet, a fix on rocprofiler-systems side is needed as well.

Technical Details

Added:

"container_options": ["--cap-add=SYS_PTRACE", "--cap-add=PERFMON"],

To rocprofiler-systems's fetch_test_configurations.py code.

Test Plan

Local testing.

Workflows

Test Result

Local testing, with fixes on rocprofiler-systems side, shows that attach can run whilst in the docker container (i.e. it won't get skipped due to missing permissions).

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/github_actions/fetch_test_configurations.py; no test file found
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@kcossett-amd
kcossett-amd force-pushed the users/kcossett-amd/add-cap-sys branch from 915df66 to 5eee8f1 Compare August 7, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant