Skip to content

Capture per-project ASAN build timing artifacts - #9345

Open
sa-faizal wants to merge 3 commits into
ROCm:mainfrom
sa-faizal:codex/asan-project-timing-artifacts
Open

sa-faizal wants to merge 3 commits into
ROCm:mainfrom
sa-faizal:codex/asan-project-timing-artifacts

Conversation

@sa-faizal

@sa-faizal sa-faizal commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Emit machine-readable per-project configure/build/install/package timings from the existing Ninja build log analyzer.
  • Retain stage build console output and map explicit Ninja FAILED: targets to ROCm component names for trustworthy failure hotspots.
  • Upload one small timing artifact for each reusable build-stage job so the rockrel dashboard can ingest project-level trends and failures automatically.

Fixes #7692

Validation

  • python -m py_compile build_tools/analyze_build_times.py
  • Synthetic Ninja log check confirmed rocBLAS/RCCL phase timing and RCCL failure attribution.
  • actionlint .github/workflows/multi_arch_build_portable_linux_artifacts.yml
  • TheRock pre-commit hooks passed locally after formatting.

Artifacts are consumed by the AMD-ROCm-TPM/Debug-at-Scale nightly snapshot refresh after this workflow change is merged.

@therock-pr-bot

therock-pr-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: build_tools/analyze_build_times.py; no test file found
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Oct 17, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@therock-pr-bot therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Oct 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

[CI] Build time analysis report is no longer generated in multi-arch workflows

1 participant