[CI] run_llama.sh: Add returncode propagation of llama-bench#2232
Merged
mhalk merged 1 commit intoMay 28, 2026
Merged
Conversation
mhalk
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
mhalk
deleted the
mhalk/amd/dev/mhalkenh/feat/ci-llama-returncode-propagation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Even when errors occurred, nothing was reported to the user or calling script.
teewould mask any returncode, e.g. 139 / SEGFAULT.Technical Details
Added wrapper for the benchmark call which has the required error handling.
That is: Print error message and capture & propagate returncode of llama-bench.
Test Plan
Small amount of manual runs, e.g. with AOMP_GPU set to a wrong GPU arch.
Test Result
Script reports errors and may return with the corresponding returncode of llama-bench.
Submission Checklist