Fix HIP assert in cooperative groups

[matyas-streamhpc]

The header was broken because asm("trap;") is a CUDA function and HIP does not support it.

The issue appeared only with the -O0 flag because of the NDEBUG switch.

The recent HIP version supports device assert, therefore we are recommending its use in the recent bug fix.

If the mentioned solution is not preferred, we can replace asm("trap;") with asm("s_trap 1;") as a working alternative.

---

The MR solves ROCm/HIP#233 and relates to ROCm/HIP#3317

Perhaps it relates to ROCm/ROCm#1729

[iassiour]

Hi @matyas-streamhpc this has already been changed in internal clr:

hip_abort is now defined like:
#define __hip_abort()
{ abort(); }

Could you please confirm that it solves the issue you are seeing. The change should become available in the next release (6.0) and should also become available in the external clr repo here with the next sync.

[matyas-streamhpc]

Thanks! I can confirm it: I tried it and it works well.