Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake warnings with newer cmake #17

Closed
wants to merge 1 commit into from

Conversation

sbalint98
Copy link

When using newer cmake (3.27.5) to build the repository as described in the How to install section, the following cmake warnings are displayed:

CMake Warning (dev) at CMakeLists.txt:45:
  Syntax Warning in cmake code at column 113

  Argument not separated from preceding token by whitespace.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:21 (project):
  cmake_minimum_required() should be called prior to this top-level project()
  call.  Please see the cmake-commands(7) manual for usage documentation of
  both commands.
This warning is for project developers.  Use -Wno-dev to suppress it.

This PR fixes these issues.

@iassiour
Copy link
Contributor

Thank you for raising this. This has already been changed in the internal clr repo and this repo will soon be updated to reflect the change. Closing the PR.

@iassiour iassiour closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants