LWPDCGSS-2256 - Improve library detection #62
Conversation
Add HINTS to find_dependency calls to ensure find_package(HIP) works without having to set ROCM_PATH or CMAKE_PREFIX_PATH
| @@ -63,7 +63,7 @@ if(NOT HIP_CXX_COMPILER) | |||
| endif() | |||
|
|
|||
| if(NOT WIN32) | |||
| find_dependency(AMDDeviceLibs) | |||
| find_dependency(AMDDeviceLibs HINTS ${ROCM_PATH}) | |||
There was a problem hiding this comment.
Shouldn't this be PATHS instead of HINTS?
According to https://cmake.org/cmake/help/latest/command/find_package.html
There was a problem hiding this comment.
not sure about this myself, I have discussed this some time with others as well and it wasn't quite clear if it should be PATHS ${ROCM_PATH}, HINTS ${ROCM_PATH} or PATHS ${ROCM_PATH} HINTS /opt/rocm
I'll defer here to reviewer choice :)
There was a problem hiding this comment.
Given that (according to cmake doc): HINTS should be paths computed by system introspection, such as a hint provided by the location of another item already found. Hard-coded guesses should be specified with the PATHS option.
I think the correct option here is HINTS ${ROCM_PATH} PATHS "/opt/rocm"
Also a note that with the proposed changes it is not necessary for user to set the ROCM_PATH environment variable. i.e. just provide the path to the rocm installation would also work i.e.
find_package(HIP CONFIG PATHS "/opt/rocm")
I have transferred the changes to an internal PR and it should appear in this repo shortly after it is merged. Will then close this PR.
Add HINTS to find_dependency calls to ensure find_package(HIP) works without having to set ROCM_PATH or CMAKE_PREFIX_PATH externally.
With this change, having find_package(HIP CONFIG PATHS $ENV{ROCM_PATH} "/opt/rocm") will properly detect the additional libaries. Without it, CMAKE_PREFIX_PATH has to be set to /opt/rocm to be able to configure