Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: automatically insert logger boilerplate config #514

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

ROpdebee
Copy link
Owner

@ROpdebee ROpdebee commented Jul 3, 2022

I keep forgetting to enable the logger in new or migrated scripts, all of them need it, and the code is mostly identical anyway. Let's automatically inject it when building it so it'll always be present.

Cherry-picked from #499.

I keep forgetting to enable the logger in new or migrated scripts,
all of them need it, and the code is mostly identical anyway. Let's
automatically inject it when building it so it'll always be present.
@ROpdebee ROpdebee added the build label Jul 3, 2022
@ROpdebee ROpdebee requested a review from kellnerd July 3, 2022 10:00
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #514 (802bb95) into main (ce6ff89) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          56       56           
  Lines        1258     1258           
  Branches      197      197           
=======================================
  Hits         1254     1254           
  Misses          3        3           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6ff89...802bb95. Read the comment docs.

@ROpdebee ROpdebee merged commit e7a6ceb into main Jul 27, 2022
@github-actions
Copy link

🚀 Released 3 new userscript version(s):

  • mb_caa_dimensions 2022.7.27 in 2a3f468
  • mb_enhanced_cover_art_uploads 2022.7.27 in 22fd718
  • mb_multi_external_links 2022.7.27 in 2c5bf7e

github-actions bot added a commit that referenced this pull request Jul 27, 2022
build: automatically insert logger boilerplate config (#514)
github-actions bot added a commit that referenced this pull request Jul 27, 2022
build: automatically insert logger boilerplate config (#514)
github-actions bot added a commit that referenced this pull request Jul 27, 2022
build: automatically insert logger boilerplate config (#514)
@ROpdebee ROpdebee deleted the inject-logger branch July 27, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant