fix(ecau): wrap long URLs in logging banners #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discogs URLs tend to overflow the logging banner. Firefox performs sub-optimal line breaking (it breaks in the middle of the URL), but Chrome performs no line breaking at all. To fix this, we'll insert word-break hints in front of all forward slashes, which should convince the browsers to perform proper line breaking. However, since it's still possible that an enormous URL without forward slashes will appear, we're also setting a CSS property to allow all browsers to do arbitrary word breaking in case it's really necessary.
github-actions bot
added a commit
that referenced
this pull request
Jul 28, 2022
fix(ecau): wrap long URLs in logging banners (#531)
|
🚀 Released 1 new userscript version(s):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discogs URLs tend to overflow the logging banner. Firefox performs sub-optimal line breaking (it breaks in the middle of the URL), but Chrome performs no line breaking at all.
To fix this, we'll insert word-break hints in front of all forward slashes, which should convince the browsers to perform proper line breaking. However, since it's still possible that an enormous URL without forward slashes will appear, we're also setting a CSS property to allow all browsers to do arbitrary word breaking in case it's really necessary.
https://community.metabrainz.org/t/ropdebees-userscripts-support-thread/551947/96?u=ropdebee
I'm borrowing a modified version of
insertBetweenfrom #499, so whenever work on that recommences, it should be synced.