Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inline recs): Show track durations; Dim current release occurrences #789

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jesus2099
Copy link
Contributor

@jesus2099 jesus2099 commented Aug 2, 2024

The goal is to emphasize the use of the recordings in other releases than the current release (which is slightly dimmed).

And displaying all those other track times helped me spot some wrong track/recording assignments.

@jesus2099
Copy link
Contributor Author

Screenshot_2024-08-03-01-15-26-423_com kiwibrowser browser
Before

Screenshot_2024-08-03-01-16-32-049_com kiwibrowser browser
After

@jesus2099 jesus2099 changed the title feat(inline recs): Show track durations and Dim also appears on current release feat(inline recs): Show track durations; Dim current release occurrences Aug 9, 2024
@jesus2099
Copy link
Contributor Author

jesus2099 commented Aug 9, 2024

I will update my old millisecond to human-readable-duration function (from mb_INLINE-STUFF) to more straightforward stuff like padStart(2, "0") so I have some cleanup to do.

But these days I'm only on smartphone so it will have to wait a little bit.

@jesus2099 jesus2099 marked this pull request as draft August 9, 2024 13:36
@jesus2099 jesus2099 marked this pull request as ready for review August 22, 2024 13:50
@jesus2099
Copy link
Contributor Author

OK, done.

And for the end squashed commit, if it is merged, the title of this PR is better than the titles of the commits, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant