feat: add comprehensive Korean language support #4334
Conversation
- Complete Korean translations for all UI components, settings, shortcuts, and error messages - Improved Korean login UI layout with natural word order - Added Korean language imports to default resource files - Enhanced formatNumber utility with Korean number formatting - Updated type definitions for better Korean language support - Maintained full backward compatibility with existing languages Co-authored-by: SungHyun Lee <[email protected]>
|
Thank you for your contribution. We will review it promptly. |
|
@hellosunghyun is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive Korean language support to Folo, including complete translations and improved UI layout optimization for Korean users. The implementation includes full translation coverage across all application components and a specialized login UI layout that provides natural Korean text rendering.
Key Changes:
- Complete Korean translations for all UI components (app, settings, shortcuts, errors, AI, mobile, native)
- Korean-specific number formatting using traditional Korean units (만/억/조)
- Language-specific login UI layout optimization for natural Korean text flow
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/internal/utils/src/utils.ts |
Added Korean-specific number formatting with traditional units and language detection caching |
packages/internal/utils/src/formatNumber.md |
Documentation for the new number formatting functionality |
packages/internal/utils/src/__tests__/formatNumber.test.ts |
Comprehensive tests for Korean number formatting |
packages/internal/shared/src/language.ts |
Added Korean language definition to action language mapping |
packages/internal/shared/src/hono.ts |
Updated type definitions to include Korean in schema validation |
locales/**/ko.json |
Complete Korean translations across all locale categories |
apps/desktop/layer/renderer/src/modules/auth/LoginModalContent.tsx |
Korean-specific login UI layout optimization |
| Various type definition files | Updated to include Korean language support in constants and resource imports |
apps/desktop/layer/renderer/src/modules/auth/LoginModalContent.tsx
Outdated
Show resolved
Hide resolved
- Rename cacheTimestamp to languageCacheTimestamp for clarity - Increase cache duration from 5s to 5m for better performance - Extract isKoreanLayout helper function for improved readability
- Remove extra keys from ko.json that don't exist in en.json - Remove shortcuts.hotkey and shortcuts.hotkey_placeholder from ai/ko.json - Remove general.data_persist keys from settings/ko.json
|
Thank you for your contribution. However, based on past experience, community-added translations often fall out of sync when we release updates. Since our team has limited capacity to maintain multiple languages, we must be selective about adding new ones. Would you be willing to take ongoing responsibility for keeping the Korean translation up to date? If the answer above is yes, then
|
|
@DIYgod I will check it periodically and contribute to Korean. |
2 participants
Summary
This PR adds comprehensive Korean language support to Folo, including complete translations and improved UI layout for Korean users.
Korean Language Support
Korean Login UI Layout Improvement
[Folo Logo] + "에 로그인"= "Folo에 로그인"Changes
Translation Files Added/Updated
locales/app/ko.json- Main app translations (including optimized signin translations)locales/common/ko.json- Common UI elementslocales/settings/ko.json- Settings page translationslocales/shortcuts/ko.json- Keyboard shortcutslocales/errors/ko.json- Error messageslocales/lang/ko.json- Language definitionslocales/ai/ko.json- AI-related translationsUI Layout Improvements
Technical Implementation
LoginModalContent.tsxformatNumberutility with Korean number formatting supportTest Plan
Notes
This comprehensive Korean language support enhances accessibility for Korean users while maintaining full compatibility with existing functionality. The implementation follows i18n best practices and ensures no impact on users of other languages. The optimized signin translations provide a cleaner separation between visual elements and localized text.
This is a fresh PR that replaces #4224 with the same changes.