Skip to content

Add ev_hc32f334_lqfp64 board and update package relation. #10522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 18, 2025
Merged

Add ev_hc32f334_lqfp64 board and update package relation. #10522

merged 4 commits into from
Jul 18, 2025

Conversation

JamieTx
Copy link
Contributor

@JamieTx JamieTx commented Jul 17, 2025 •
edited
Loading

拉取/合并请求描述：(PR description)

[
Add ev_hc32f334_lqfp64 board and update package relation.

Packages repositories PR: RT-Thread/packages#1915
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label Jul 17, 2025
@kurisaW
Copy link
Member

kurisaW commented Jul 17, 2025

作者麻烦在这里加一下ev_hc32f334_lqfp64 的CI看护

rt-thread/.github/ALL_BSP_COMPILE.json

Line 48 in 542d65b

"hc32/ev_hc32f4a0_lqfp176",

另外如果感兴趣的话，可以参与到HC32 bsp的审核中，可以修改MAINTAINERS文件，后续有HC32相关PR会自动任命你为审核者

https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

@kurisaW kurisaW mentioned this pull request Jul 17, 2025
Merged
10 tasks
@kurisaW
Copy link
Member

kurisaW commented Jul 17, 2025

LGTM

@JamieTx JamieTx requested a review from supperthomas as a code owner July 18, 2025 02:14
@github-actions github-actions bot added the action github action yml imporve label Jul 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: maintainers

Reviewers: Rbb666 kurisaW

Changed Files (Click to expand)
  • MAINTAINERS

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-07-18 13:41 CST)

  • ⌛ Rbb666 Pending Review
  • ✅ kurisaW Reviewed On 2025-07-17 19:10 CST
  • ⌛ supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@JamieTx
Copy link
Contributor Author

JamieTx commented Jul 18, 2025

作者麻烦在这里加一下ev_hc32f334_lqfp64 的CI看护

rt-thread/.github/ALL_BSP_COMPILE.json

Line 48 in 542d65b

"hc32/ev_hc32f4a0_lqfp176",

另外如果感兴趣的话，可以参与到HC32 bsp的审核中，可以修改MAINTAINERS文件，后续有HC32相关PR会自动任命你为审核者

https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS

已修改，并添加相关人员作为审核者。

kurisaW
kurisaW reviewed Jul 18, 2025
View reviewed changes
MAINTAINERS Outdated
@@ -83,6 +83,30 @@ tag: bsp_gd32470z-lckfb
path: bsp/gd32/arm/gd32470z-lckfb
owners: Wu Ying Xiang(godmial)<[email protected]>

tag: bsp_ev_hc32f4a0_lqfp176
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议这边直接对bsp/hc32进行看护:

tag: bsp_hc32
path: bsp/hc32
owners: Levi Zhang(levizh)[email protected]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，我改下

kurisaW
kurisaW reviewed Jul 18, 2025
View reviewed changes
MAINTAINERS Outdated
@@ -83,6 +83,10 @@ tag: bsp_gd32470z-lckfb
path: bsp/gd32/arm/gd32470z-lckfb
owners: Wu Ying Xiang(godmial)<[email protected]>

tag: bsp_hc32
Copy link
Member

@kurisaW kurisaW Jul 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个要按照字母顺序排序的，不然不好快速定位maintainers，作者可以麻烦您再帮忙改下嘛，其他我没问题了，感谢作者贡献！

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

失误，已调整。

@Rbb666 Rbb666 merged commit 4423c6f into RT-Thread:master Jul 18, 2025
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurisaW kurisaW kurisaW left review comments

@Rbb666 Rbb666 Rbb666 approved these changes

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

Assignees
No one assigned
Labels
action github action yml imporve BSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieTx @kurisaW @Rbb666