Skip to content

utilize the clang-format-ignore mechanism in bsp/nxp (#10764) #10827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

utilize the clang-format-ignore mechanism in bsp/nxp (#10764) #10827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb305ea
utilize the clang-format-ignore mechanism in bsp/nxp
thomax2 Oct 16, 2025
261b8c7
fix: ignore files with known build issues exposed by migration
thomax2 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions bsp/nxp/imx/imxrt/imxrt1060-nxp-evk/.clang-format-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# .clang-format-ignore File Description:
# ----------------------------------------------------------------------------------------
# 1. Used to specify which files or directories should be skipped by the clang-format tool.
# 2. Follows syntax rules similar to .gitignore.
# 3. Supports wildcard patterns and path matching.
# 4. clang-format will recursively apply the .clang-format-ignore rules.

# NXP imxrt1060-nxp-evk library
/board/board.c
/board/MCUX_Config/
/xip/
6 changes: 0 additions & 6 deletions bsp/nxp/imx/imxrt/imxrt1060-nxp-evk/.ignore_format.yml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions bsp/nxp/imx/imxrt/libraries/.clang-format-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# .clang-format-ignore File Description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件可以删掉

# ----------------------------------------------------------------------------------------
# 1. Used to specify which files or directories should be skipped by the clang-format tool.
# 2. Follows syntax rules similar to .gitignore.
# 3. Supports wildcard patterns and path matching.
# 4. clang-format will recursively apply the .clang-format-ignore rules.

# NXP IMXRT library
/MIMXRT1060/
4 changes: 0 additions & 4 deletions bsp/nxp/imx/imxrt/libraries/.ignore_format.yml
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions bsp/nxp/lpc/lpc55sxx/Libraries/.clang-format-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# .clang-format-ignore File Description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件不需要，可以删掉，驱动库已经做成软件包了

# ----------------------------------------------------------------------------------------
# 1. Used to specify which files or directories should be skipped by the clang-format tool.
# 2. Follows syntax rules similar to .gitignore.
# 3. Supports wildcard patterns and path matching.
# 4. clang-format will recursively apply the .clang-format-ignore rules.

# NXP LPC55Sxx library
/LPC55S6X/
/LPC55S06/
/LPC5502/
/LPC55S28/
/LPC55S36/
8 changes: 0 additions & 8 deletions bsp/nxp/lpc/lpc55sxx/Libraries/.ignore_format.yml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions bsp/nxp/mcx/mcxa/Libraries/.clang-format-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# .clang-format-ignore File Description:
# ----------------------------------------------------------------------------------------
# 1. Used to specify which files or directories should be skipped by the clang-format tool.
# 2. Follows syntax rules similar to .gitignore.
# 3. Supports wildcard patterns and path matching.
# 4. clang-format will recursively apply the .clang-format-ignore rules.

# NXP MCXA library
/MCXA153/
4 changes: 0 additions & 4 deletions bsp/nxp/mcx/mcxa/Libraries/.ignore_format.yml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions bsp/nxp/mcx/mcxc/Libraries/.clang-format-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# .clang-format-ignore File Description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以删掉

# ----------------------------------------------------------------------------------------
# 1. Used to specify which files or directories should be skipped by the clang-format tool.
# 2. Follows syntax rules similar to .gitignore.
# 3. Supports wildcard patterns and path matching.
# 4. clang-format will recursively apply the .clang-format-ignore rules.

# NXP MCXC library
/MCXC444/
4 changes: 0 additions & 4 deletions bsp/nxp/mcx/mcxc/Libraries/.ignore_format.yml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions bsp/nxp/mcx/mcxn/Libraries/.clang-format-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# .clang-format-ignore File Description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以删掉

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自动化流程有两个报错
1.
RT-Thread BSP Static Build Check / arm-none-bsp-smart (pull_request)Failing after 1m
[cpp_check.py 80 INFO]
[cpp_check.py 79 INFO] Checking components/drivers/ktime/src/hrtimer.c ...
Checking components/drivers/ktime/src/hrtimer.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;...
Checking components/drivers/ktime/src/hrtimer.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;ARCH_CPU_64BIT...

[cpp_check.py 80 INFO]
[cpp_check.py 79 INFO] Checking components/lwp/lwp.c ...
Checking components/lwp/lwp.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;RT_USING_DFS=1;RT_USING_MUSLLIBC...

[cpp_check.py 80 INFO]
[cpp_check.py 79 INFO] Checking components/utilities/utest/utest.c ...

[cpp_check.py 80 INFO] components/utilities/utest/utest.c:26:2: error: #error "RT_CONSOLEBUF_SIZE is less than 256!" [preprocessorErrorDirective]
#error "RT_CONSOLEBUF_SIZE is less than 256!"
^

[cpp_check.py 79 INFO] Checking libcpu/aarch64/common/mmu.c ...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;ARCH_USING_ASID...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;KERNEL_ASPACE_START...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;RT_DEBUGGING_ALIASING...
Checking libcpu/aarch64/common/mmu.c: RT_ASSERT(x)=;RTM_EXPORT(x)=;rt_list_for_each_entry(a,b,c)=a=(void*)b;;RT_USING_SMART...

[cpp_check.py 80 INFO]
[cpp_check.py 111 ERROR] static code analysis(cppcheck) fail.
Error: Process completed with exit code 1.

2.
Static code analysis / Static code analysis (pull_request)Failing after 2m
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/board.c:18:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/bsp_clock.c:12:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/drv_common.c:14:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
In file included from drivers/imx6ull.h:18,
from drivers/board.h:14,
from drivers/drv_common.h:15,
from drivers/drv_adc.c:24:
/home/runner/work/rt-thread/rt-thread/components/lwp/lwp.h:88:2: error: #error "No compatible lwp set status provided for this libc"
88 | #error "No compatible lwp set status provided for this libc"
| ^~~~~
scons: *** [build/drivers/board.o] Error 1
scons: *** [build/drivers/bsp_clock.o] Error 1
drivers/drv_adc.c:32:17: warning: 'imx6ull_adc_convert' defined but not used [-Wunused-function]
32 | static rt_err_t imx6ull_adc_convert(struct rt_adc_device *device, rt_uint32_t channel, rt_uint32_t *value)
| ^~~~~~~~~~~~~~~~~~~
drivers/drv_adc.c:27:17: warning: 'imx6ull_adc_enabled' defined but not used [-Wunused-function]
27 | static rt_err_t imx6ull_adc_enabled(struct rt_adc_device *device, rt_uint32_t channel, rt_bool_t enabled)
| ^~~~~~~~~~~~~~~~~~~
scons: *** [build/drivers/drv_common.o] Error 1
scons: *** [build/drivers/drv_adc.o] Error 1
scons: building terminated because of errors.
scons -c
Error: build nxp/imx/imx6ull-smart failed
Error: Process completed with exit code 1.
我看 和 .clang-format-ignore 修改无关，需要做什么使检查通过么？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用处理，这是其他bsp遗留的问题，与该PR无关

# ----------------------------------------------------------------------------------------
# 1. Used to specify which files or directories should be skipped by the clang-format tool.
# 2. Follows syntax rules similar to .gitignore.
# 3. Supports wildcard patterns and path matching.
# 4. clang-format will recursively apply the .clang-format-ignore rules.

# NXP MCXN library
/MCXN947/
4 changes: 0 additions & 4 deletions bsp/nxp/mcx/mcxn/Libraries/.ignore_format.yml
View file
Open in desktop

This file was deleted.

Loading