Skip to content

bsp: k230: add i2c driver #10861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

bsp: k230: add i2c driver #10861

merged 1 commit into from
Oct 29, 2025
+1,491 −1

Conversation

@Ze-Hou
Copy link
Contributor

@Ze-Hou Ze-Hou commented Oct 28, 2025

Continue from #10851
删除从机部分
Requirement: The BSP for the k230 platform in the RT-Thread repository
does not yet have an I2C driver.

    Solution: Provide I2C driver for the k230 platform in the RT-Thread
    repository.
    1. support i2c master mode

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@Ze-Hou
bsp: k230: add i2c driver
047fdaa 
        Requirement: The BSP for the k230 platform in the RT-Thread repository
        does not yet have an I2C driver.

        Solution: Provide I2C driver for the k230 platform in the RT-Thread
        repository.
        1. support i2c master mode

Signed-off-by: Ze-Hou <[email protected]>
@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：master
  • 设置PR number为 \ Set the PR number to：10861
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 master 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the master branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added the BSP label Oct 28, 2025
@github-actions
Copy link

📌 Code Review Assignment

🏷️ Tag: bsp_k230

Reviewers: @unicornx

Changed Files (Click to expand)
  • bsp/k230/.ci/attachconfig/ci.attachconfig.yml
  • bsp/k230/.config
  • bsp/k230/board/Kconfig
  • bsp/k230/drivers/interdrv/i2c/SConscript
  • bsp/k230/drivers/interdrv/i2c/drv_i2c.c
  • bsp/k230/drivers/interdrv/i2c/drv_i2c.h
  • bsp/k230/drivers/utest/SConscript
  • bsp/k230/drivers/utest/test_i2c.c
  • bsp/k230/rtconfig.h

📊 Current Review Status (Last Updated: 2025-10-28 15:22 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@unicornx unicornx self-requested a review October 29, 2025 01:03
unicornx
unicornx approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@unicornx unicornx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只有一个小问题见下，其他 LGTM

另外记得以后 pr 时要从 master 上拉一个自己的开发分支，不要用master 分支开发，容易引起混淆。

bsp/k230/drivers/interdrv/i2c/drv_i2c.c
return k230_i2c_xfer_finish(dev);
}

static int _k230_i2c_write(struct k230_i2c_dev *dev)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥这个函数的函数名要以下划线开头？和其他 static 函数有啥区别？如果没有请统一风格。

其他下划线开头的函数都检查一下。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当时想的是这两个是服务xfer的内部函数就在前边加了下划线

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥这个函数的函数名要以下划线开头？和其他 static 函数有啥区别？如果没有请统一风格。

其他下划线开头的函数都检查一下。

那这个问题要统一吗

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥这个函数的函数名要以下划线开头？和其他 static 函数有啥区别？如果没有请统一风格。
其他下划线开头的函数都检查一下。

那这个问题要统一吗

你自己定吧，我已经 approve 了

@Ze-Hou
Copy link
Contributor Author

Ze-Hou commented Oct 29, 2025

只有一个小问题见下，其他 LGTM

另外记得以后 pr 时要从 master 上拉一个自己的开发分支，不要用master 分支开发，容易引起混淆。

好的

@unicornx unicornx requested a review from Rbb666 October 29, 2025 01:29
@unicornx
Copy link
Contributor

@Rbb666 请 review，如ok请 merge

@Rbb666 Rbb666 added the BSP: K230 BSP related with K230 label Oct 29, 2025
@Rbb666 Rbb666 added this to the v5.2.2 milestone Oct 29, 2025
@Rbb666 Rbb666 merged commit 9e31279 into RT-Thread:master Oct 29, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 approved these changes

+1 more reviewer

@unicornx unicornx unicornx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BSP: K230 BSP related with K230 BSP

Projects

None yet

Milestone

v5.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Ze-Hou @unicornx @Rbb666