Skip to content

Add patches for ADC peripherals #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2020
Merged

Add patches for ADC peripherals #29

merged 3 commits into from
Jul 26, 2020

Conversation

lperlaki
Copy link
Contributor

Patch needed for ADC implementation
currently only atmega328p

avr-hal/11

@lperlaki lperlaki mentioned this pull request Jul 25, 2020
Merged
@Rahix
Copy link
Owner

Rahix commented Jul 25, 2020

From a quick look, this patch should also be applied for ATmega1280, ATmega32U4, and ATmega64. Would you mind adding that to this PR?

Rahix
Rahix approved these changes Jul 25, 2020
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Rahix Rahix changed the title Adc implementation Add patches for ADC peripherals Jul 26, 2020
@Rahix Rahix merged commit 1969ec3 into Rahix:master Jul 26, 2020
@lperlaki lperlaki deleted the adc branch July 26, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lperlaki @Rahix